This repository has been archived by the owner on Mar 17, 2020. It is now read-only.
Enable excerpt generation by both BeautifulSoup & lxml #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| import bs4 | ||
| except ImportError: | ||
| print("\nlxml or bs4 is required in order to create post excerpts.") | ||
| print("See http://lxml.de/installation.html for installation " | ||
| "instructions.") | ||
| print("You can also turn off post excerpts in your _config.py:") |
There was a problem hiding this comment.
If I understand the indentation correctly, would not this message be printed (and exit(1) issued in the following line) even if BeautifulSoup was imported without problems?
|
Thanks for the pull request and code review. I'm presently travelling with sporadic, limited network access, so it will be couple of weeks before I can do anything with this. Thanks for your patience. |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is addressing the issue referenced here: #19 and here: https://groups.google.com/forum/#!topic/blogofile-discuss/7Y7eXWOH29o/discussion
I wasn't able to figure out to add the pull request to the existing issue, so I created a new one.
I tried to follow the coding standards of the rest of the code. Please let me know if something needs to be changed.
Thanks!