Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schematic caching system for suggestions #2542

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Schematic caching system for suggestions #2542

wants to merge 10 commits into from

Commits on Jun 1, 2024

  1. Implement SchematicsManager to cache list of known schematics

    @seijikun @me4502
    seijikun authored and me4502 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    ec1c7f6 View commit details
    Browse the repository at this point in the history

  2. Add command suggestions for schematic filenames

    @seijikun @me4502
    seijikun authored and me4502 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    e5f9212 View commit details
    Browse the repository at this point in the history

  3. Rename Schematic to SchematicPath and cleanup 

    - Resolve first batch of review comments
  - Renamed Schematic to SchematicPath
  - Removed custom hashCode() and equals() implementations
  - Added unit-test to make sure it behaves as expected
    @seijikun @me4502
    seijikun authored and me4502 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    0551ff6 View commit details
    Browse the repository at this point in the history

  4. Remove unncessary (un)init log points

    @seijikun @me4502
    seijikun authored and me4502 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    efb6304 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Octavia Togami <[email protected]>
    @me4502 @octylFractal
    me4502 and octylFractal committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    64d8e39 View commit details
    Browse the repository at this point in the history

  6. Resolve many of octy's review notes

    @me4502
    me4502 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    4f3ad0c View commit details
    Browse the repository at this point in the history

  7. Further review fixes

    @me4502
    me4502 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    0c7f5f6 View commit details
    Browse the repository at this point in the history

  8. Further review improvements

    @me4502
    me4502 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    92a3ad2 View commit details
    Browse the repository at this point in the history

  9. Fix symlink check

    @me4502
    me4502 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    05b229a View commit details
    Browse the repository at this point in the history

  10. PR notes

    @me4502
    me4502 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    ff6393e View commit details
    Browse the repository at this point in the history