Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Folia basic support; #2379

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add Folia basic support; #2379

wants to merge 4 commits into from

Conversation

HarvelsX
Copy link

@HarvelsX HarvelsX commented Aug 3, 2023

Adds adapters for schedulers. Required for Bukkit and Folia schedulers.
Created schedulers can be used in WorldGuard and in other plugins;

  • Tested in detail

Copy link
Member

@octylFractal octylFractal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure this covers all the changes we'd need to be properly folia-supportive, but one thing for sure is I don't think we want to expose SchedulerAdapter + these Entity methods as full API. I think those belong specifically in the Bukkit section. I'm not sure we'd even like to have them be public there, but that's a discussion I'd need to have with the rest of the dev team.

@Yomamaeatstoes
Copy link

When testing whether this project would build in Ubuntu I did encounter a build failure. I pasted it in mclogs
https://mclo.gs/PXagKd8. When I tried building it in Terminal I did encounter this issue as well. I suppose they could be apart of the same issue https://mclo.gs/FGdD5KX

@octylFractal
Copy link
Member

Yes, the new API must be accepted.

Euphillya added a commit to Euphillya/WorldEdit-Folia that referenced this pull request Dec 21, 2023
@octylFractal octylFractal mentioned this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants