-
-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NBT Parsing for items #1611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1611 +/- ##
============================================
- Coverage 11.80% 11.45% -0.35%
+ Complexity 1055 1002 -53
============================================
Files 801 804 +3
Lines 32703 32577 -126
Branches 3801 3738 -63
============================================
- Hits 3860 3732 -128
- Misses 28654 28667 +13
+ Partials 189 178 -11
Continue to review full report at Codecov.
|
me4502
force-pushed
the
feature/nbt-parsing
branch
from
December 23, 2020 10:50
e9c90d7
to
d82c612
Compare
me4502
force-pushed
the
feature/nbt-parsing
branch
from
January 16, 2021 04:30
0b9c8d5
to
252e605
Compare
octylFractal
added
the
status:accepted
Will be fixed / added to WorldEdit, eventually
label
Jan 18, 2021
me4502
force-pushed
the
feature/nbt-parsing
branch
3 times, most recently
from
February 3, 2021 11:41
1b58d7b
to
3365963
Compare
me4502
force-pushed
the
feature/nbt-parsing
branch
from
February 5, 2021 12:40
43688da
to
ed41a87
Compare
me4502
force-pushed
the
feature/nbt-parsing
branch
from
February 6, 2021 10:23
5f7c2a9
to
137c266
Compare
me4502
force-pushed
the
feature/nbt-parsing
branch
from
February 8, 2021 12:08
d03fb8d
to
4ac2bb3
Compare
octylFractal
force-pushed
the
feature/nbt-parsing
branch
from
February 15, 2021 10:08
b36b06b
to
b7880c2
Compare
octylFractal
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status:accepted
Will be fixed / added to WorldEdit, eventually
type:feature-request
Request for something new
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing NBT data in the item parser.
This is a precursor for "Tools v2".
Ideally we can also remove the existing NBT classes once we switch to
adventure-nbt
.EngineHub/worldedit-adapters#23