Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearblocks.js CraftScript #1370

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

JsKingBoo
Copy link

The contents of this CraftScript is less concerned about being useful and more focused on demonstrating the CraftScript API for aspiring developers. Thus the code performs an operation that is short and easy to understand.

@octylFractal
Copy link
Member

.py 🤔

@JsKingBoo JsKingBoo changed the title Add clearblocks.py CraftScript Add clearblocks.js CraftScript Jun 22, 2020
@JsKingBoo
Copy link
Author

JsKingBoo commented Jun 22, 2020

MCEdit filter roots run deep

fixed ty

contrib/craftscripts/clearblocks.js Outdated Show resolved Hide resolved
contrib/craftscripts/clearblocks.js Outdated Show resolved Hide resolved
@wizjany
Copy link
Collaborator

wizjany commented Jun 27, 2020

🤔

@JsKingBoo
Copy link
Author

smh my head

fixed comment

@octylFractal octylFractal added the status:accepted Will be fixed / added to WorldEdit, eventually label Aug 8, 2020
@octylFractal octylFractal added the type:feature-request Request for something new label Jan 18, 2021
var height = region.getHeight()
var length = region.getLength()

function sidesExposed(block) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire function can be replaced by the #surface mask, don't recall the exact implementing class but it should be sufficient. I would rather not add more clunky code for us to maintain in the craftscripts dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:feature-request Request for something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants