Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues around dicom_ul::get_client_pdu #590

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Nov 2, 2024

Summary

  • [ul] adjust get_client_pdu to prevent trailing data loss
  • [ul] optimize get_client_pdu to not allocate a Vec per reader buffer fill
  • [scpproxy] Tweak dicom-scpproxy to handle `dicom_ul closed connection errors correctly

Enet4 added 3 commits November 2, 2024 09:27
- add `read_buffer` parameter
  to hold and retain arbitrary chunks of incoming data
  in subsequent calls
- [scpproxy] adjust usage accordingly
@Enet4 Enet4 added bug This is a bug A-lib Area: library C-ul Crate: dicom-ul C-scpproxy Crate: dicom-scproxy labels Nov 2, 2024
@Enet4 Enet4 added this to the DICOM-rs 0.8 milestone Nov 2, 2024
@Enet4 Enet4 merged commit 6c44c43 into master Nov 2, 2024
4 checks passed
@Enet4 Enet4 deleted the bug/ul/get_client_pdu-mitigation branch November 2, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lib Area: library bug This is a bug C-scpproxy Crate: dicom-scproxy C-ul Crate: dicom-ul
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant