This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Feedback Requested: Print Helm Release Output #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I'll have a look, probably later this week, thanks so far! |
|
I haven't forgotten you, will take some additional time, sorry about that. |
|
@philipbjorge Nice, I like the functionality. I agree, some mechanism too reduce the noise (or opt-in for noise) makes sense. Apart from the obvious things (make the tests run, handle any |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #78
Helm does not expose their printRelease function publicly, and this functionality is built into their commands (which landscaper does not call), so I've added a little fork of their method.
Since this has the potential to be noisy, I'm thinking it makes sense to have this turned off with a flag? Thoughts on a flag name?
I don't think bundling this under the
--verboseflag makes sense, as I don't want to show any of the other debug output myself.Assuming I put this behind a flag, anything else you'd like addressed?