feat(wallet-mobile): Add in-app notifications #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's merge #3744 first. Note the target branch is not |
3 tasks
stackchain
reviewed
Jan 6, 2025
| pushEvent(event) | ||
| } | ||
|
|
||
| if (event.trigger === Notifications.Trigger.TransactionReceived && event.metadata.walletId === selectedWalletId) { |
There was a problem hiding this comment.
topic to discuss with product, since if you have wallet X open and Y is syncing in background, should we display the other wallet messages? otherwise when switching the wallet it will send all notifications in one shot E.g if the wallet Y received 10 txs while X was open. (not a blocker for this PR tho)
There was a problem hiding this comment.
I'll have a look
stackchain
reviewed
Jan 6, 2025
| const {styles} = useStyles() | ||
| return ( | ||
| <View style={styles.absolute}> | ||
| <SafeAreaView edges={['top']}> |
There was a problem hiding this comment.
is it a Screen? if it is please add to the file name (convention)
There was a problem hiding this comment.
Not a screen, just the layout where the in-app notification is shown. Similar to our modals.
stackchain
reviewed
Jan 6, 2025
stackchain
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Change(s) / Related issue(s)
Add in app notifications
Ticket
YV-157