Install mpl differently, bring windows back #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmahsereci
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
LGTM! Thanks @apaleyes !
Just so I understand, with this workaround, some of the plotting functionality of GPy won't work correctly? (But we don't mind this). Could you also link the related GPy issue (in case there is one)?
possibly! for whatever reason GPy[plotting] fixes a very particular version of mpl that itself cannot be installed on windows
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #461
Description of changes: Instead of relying on GPy that hardcodes matplotlib version (which seems broken, see issue), let's install matplotlib separately. GPy, unfortunately, still requires matplotlib implicitly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.