Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend support for new cycling workflow #50

Merged

Conversation

edan-bainglass
Copy link
Collaborator

@edan-bainglass edan-bainglass commented Aug 30, 2023

NOTE: this PR sits on top of #54

This PR adds frontend support for the new cycling workflow. A new protocol (multi-)selector has been added, with the previous custom protocol widget moved to a "create" tab allowing users to create/save new protocols to be selected from the "select" tab. The tomato settings widget was modified to support multiple protocols, each with its own settings/monitors. The experiment builder was modified w.r.t. these changes.

Finally, the submission process was modified to support the above features.

@edan-bainglass
Copy link
Collaborator Author

@ramirezfranciscof apologies for the somewhat final two large commits. I've been dealing with various bugs all day. Got burnt out a bit towards the end there 😮‍💨

@edan-bainglass edan-bainglass force-pushed the cycling-workflow branch 3 times, most recently from 1e5beab to 6266662 Compare September 6, 2023 03:27
@edan-bainglass edan-bainglass mentioned this pull request Sep 6, 2023
@edan-bainglass
Copy link
Collaborator Author

Regarding the last commit updating the input preview section - we could consider refactoring this section into a class. Ideally, the entire submit_experiment.py file should be refactored, as should most of the app, into smaller MVC units, with the (M)odels connected in a network (see issue #55)

@edan-bainglass edan-bainglass merged commit 1a7ca53 into EmpaEconversion:main Sep 7, 2023
1 check passed
@edan-bainglass edan-bainglass deleted the cycling-workflow branch September 7, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant