Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizer-support #36

Merged

Conversation

edan-bainglass
Copy link
Collaborator

@edan-bainglass edan-bainglass commented Oct 25, 2023

Various changes and bug fixes required to support EmpaEconversion/aiidalab-aurora#42.

Copy link
Collaborator

@lorisercole lorisercole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I have just added a couple of comments. Of course I have no way to test it, so let Francisco or Peter review as well, if you deem it necessary.

aiida_aurora/utils/cycling_analysis.py Show resolved Hide resolved
aiida_aurora/utils/parsers.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@edan-bainglass edan-bainglass force-pushed the visualizer-support branch 2 times, most recently from e50a01f to 5e8f5ed Compare October 27, 2023 09:57
@edan-bainglass edan-bainglass merged commit 0753d5a into EmpaEconversion:main Nov 1, 2023
3 checks passed
@edan-bainglass edan-bainglass deleted the visualizer-support branch November 1, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants