fix: checks if files end with newline. closes #13 #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: checks if files end with newline.
Changes:
alxcheck\main.py:
".md"
inline 26
to ensure files with .md extensions are checked for newline.alxcheck\checks\general.py:
check_file_ends_with_new_line
function. Files should open inbinary mode
instead ofread text mode
. Instead usingread()
toreturn a single string containing the entire content
,readlines()
was used toreturn list of lines
.