FIX: Ignore empty __init__.py. Closes #5 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adobki
commented
Nov 18, 2023
adobki
commented
Skips all checks on empty __init__.py files. CHANGES alxcheck/utils/helpers.py + Add is_empty_init_py function helper function for skipping all checks on empty __init__.py. alxcheck/checks/general.py: * Fix typo: Remove trailing S in function name check_file_ends_with_new_line. alxcheck/main.py + Print no_ending_new_line error only if new function returns False * Make Python checks conditional/based on new check's output.
Skips all checks on empty __init__.py files. CHANGES alxcheck/utils/helpers.py + Add is_empty_init_py function helper function for skipping all checks on empty __init__.py. alxcheck/checks/general.py: * Fix typo: Remove trailing S in function name check_file_ends_with_new_line. alxcheck/tests/test_general.py: * Fix typo: Remove trailing S in function name check_file_ends_with_new_line. alxcheck/main.py + Print no_ending_new_line error only if new function returns False * Make Python checks conditional/based on new check's output.
Emmo00
approved these changes
Nov 19, 2023
LOL. No problems. I'd send you a #DM. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.