Incompatibility with eslint v4 #490
Assignees
Labels
Comments
|
Yes I am aware of that problem :s The problem is related to the tests we are running on our documentation I think. |
|
For the moment, I have just commented the testDocs method in the gulpfile config file. |
edmorley
added a commit
to mozilla/treeherder
that referenced
this issue
Jan 4, 2018
Found by adjusting the eslint `no-unused-vars` rule, changing the `args` preference from `after-used` to `all`: https://eslint.org/docs/rules/no-unused-vars.html#options That rule is too noisy to enable by default. Ideally we could use the AngularJS eslint plugin/config (which has specific rules for this), but it's not compatible with latest eslint: EmmanuelDemey/eslint-plugin-angular#490 Unless these DI parameters can have side-effects I'm not aware of, this change should be reasonably safe, since eslint's `no-undef` rule will error if anything was removed that was being directly referenced.
edmorley
added a commit
to mozilla/treeherder
that referenced
this issue
Jan 4, 2018
Found by adjusting the eslint `no-unused-vars` rule, changing the `args` preference from `after-used` to `all`: https://eslint.org/docs/rules/no-unused-vars.html#options That rule is too noisy to enable by default. Ideally we could use the AngularJS eslint plugin/config (which has specific rules for this), but it's not compatible with latest eslint: EmmanuelDemey/eslint-plugin-angular#490 Unless these DI parameters can have side-effects I'm not aware of, this change should be reasonably safe, since eslint's `no-undef` rule will error if anything was removed that was being directly referenced.
edmorley
added a commit
to mozilla/treeherder
that referenced
this issue
Jan 7, 2018
Found by adjusting the eslint `no-unused-vars` rule, changing the `args` preference from `after-used` to `all`: https://eslint.org/docs/rules/no-unused-vars.html#options That rule is too noisy to enable by default. Ideally we could use the AngularJS eslint plugin/config (which has specific rules for this), but it's not compatible with latest eslint: EmmanuelDemey/eslint-plugin-angular#490 Unless these DI parameters can have side-effects I'm not aware of, this change should be reasonably safe, since eslint's `no-undef` rule will error if anything was removed that was being directly referenced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems like 6a0111d, which upgrades the dependency to version 4 of eslint, broke the build. From what I see, the problem is this.
I'm not familiar enough with the codebase to propose a solution, except "downgrade to v3". It seems like custom properties in test cases are used a lot, so fixing it it's not trivial, but let me know if I can help in some way.
The text was updated successfully, but these errors were encountered: