[WIP] add #[spirv(typed_buffer)]
for explicit SpirvType::InterfaceBlock
s.
#1014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened as draft because it's somewhat incomplete, but I want it out of the way for now.
This PR adds a
TypedBuffer<T>
"handle" type tospirv-std
(comparable toImage
types in some respects).While not a perfect representation of the Vulkan/SPIR-V buffer model, we can't do much better for now.
With
TypedBuffer<T>
, we can now redefine the existing usage patterns:as sugar1 for:
1 (which we will continue to support for the foreseeable future, presumably)
(comparable to
buffer { uint data[]; } storage_buffer;
in GLSL)That is, plain Rust references are used to describe a single buffer, with the Rust type (
MyConstData
or[u32]
) being for the buffer contents, used to interpret the raw bytes (provided to the host, e.g. Vulkan, API).Because the "buffer handle" is made explicit, specifying multiple buffers is unambiguous:
(comparable to
buffer { uint data[]; } storage_buffers[];
in GLSL)In other words, each
TypedBuffer
Rust value corresponds exactly to one buffer descriptor (e.g.VkBuffer
).TODO(@eddyb): add changelog, tests, discuss
UntypedBuffer
(TypedBuffer<[u32]>
wrapper), maybe deprecateByteAddressibleBuffer
(to rename it toByteAddressibleView
or something? unsure what's best here)