Improve sync times #185
Merged
Improve sync times #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit uglier than I would like, but unfortunately we can't ship off the async task join to a tokio task as we spawn so many tasks that tokio won't schedule it. So instead we spawn the rayon scope on a separate thread first. This cuts sync times by ~25+%
This test is kind of redundant to diff_cargo, but I was using it to sanity check that we are 100% not giving cargo any work to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a sanity check test to ensure cargo doesn't need to do work after we use cargo-fetcher, and while doing this noticed the error that I introduced in #181 that caused sync times to be slower than the non-async version.