Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal: faster line drawing that does not affect the main thread as much #8

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

andrew-raphael-lukasik
Copy link
Contributor

@andrew-raphael-lukasik andrew-raphael-lukasik commented Aug 29, 2021

This fork implements small external https://github.com/andrew-raphael-lukasik/Segments package. It's goal is to introduce simple and cheap line rendering for dots. It delivers on that to some extent but has few drawbacks too: no Shader Graph (as it doesn't allow geometry shaders) and orthographic projects is not really implemented yet (works but not perfectly there).

Feel free to reject this PR if you're not convinced. It's just my proposal to lower cpu usage for laser line drawing which I noticed was affecting the framerate in some cases (a lot of Fighter ships attacking at once).

@andrew-raphael-lukasik
Copy link
Contributor Author

andrew-raphael-lukasik commented Aug 29, 2021

Note :

This PR is branched out from #7 PR, so probably better to consider #7 first.

It's basically just a single f22b9f4 commit.

@ElliotB256
Copy link
Owner

I'll certainly agree the line drawing I have in there is very prototypical! My long term hope was that Unity would come along with a DOTS compliant particle system before too long, but its now clear that while take a while.

I'll review this properly when I get a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants