Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #4

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Bug fixes #4

merged 3 commits into from
Sep 16, 2024

Conversation

ElianHugh
Copy link
Owner

No description provided.

Add validation tests
- check path length
- add more config validation tests

Update engine.R

nope

windows!!

WIP

- `%||%` fallback
- Use examplesIf
- Remove pipes for better compatibility (should check what version of R current plumber is compatible with)
- Remove default values for install/uninstall (should do something with the enum)
- Set minimum plumber version (probably too early a version, should check)

WIP

Minor docs and action changes

is it autostart?

How about this?

Revert

- Perhaps it's the httpuv client not closing fast enough when it finds a new port?

Update engine.R

Update engine.R

that really shouldn't have worked

cleanup

Update engine.R

Update engine.R
@ElianHugh ElianHugh marked this pull request as ready for review September 16, 2024 07:46
@ElianHugh ElianHugh merged commit 7dcfaf5 into main Sep 16, 2024
5 checks passed
@ElianHugh ElianHugh deleted the bug-fixes branch September 16, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant