Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated wandb logger to use new_printer() instead of get_printer(...) #2484

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

alex-titterton
Copy link
Contributor

Following issue #2483 this is a proposed quick-fix for the Weights and Biases logger to use the new new_printer() function instead of the now-removed get_printer(...) function in the wandb API.

I've briefly tested that a reproducer like the following works ok, but have not done any extensive testing otherwise:

lm_eval \
    --model hf \
    --model_args pretrained=meta-llama/Llama-3.2-1B,dtype="float" \
    --tasks arc_easy \
    --device cuda:0 \
    --wandb_args project=lm-eval-logger-repro

I hope this helps!

Thanks,
Alex

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2024

CLA assistant check
All committers have signed the CLA.

@baberabb baberabb mentioned this pull request Nov 12, 2024
@baberabb
Copy link
Contributor

LGTM! just need you to run the pre-commit.

@alex-titterton
Copy link
Contributor Author

Apologies, something went awry with the pre-commit, should be good now

@baberabb baberabb merged commit 67db63a into EleutherAI:main Nov 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants