Fix float limit override #2325
Merged
Fix float limit override #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: EleutherAI#2324 The float limit will be override with the previous int limit of multiple tasks are triggered together. This PR fix this issue
cjluo-omniml
requested review from
haileyschoelkopf,
lintangsutawika and
baberabb
as code owners
|
|
baberabb
reviewed
Sep 27, 2024
|
sorry @cjluo-omniml , didn't know you had to commit review comments :S. Basically |
|
@baberabb could you help rebase this? Not sure why the unittests are failing |
|
Test failure unrelated (due to a change in |
haileyschoelkopf
approved these changes
Oct 7, 2024
mariagrandury
pushed a commit
to somosnlp/lm-evaluation-harness
that referenced
this pull request
Oct 9, 2024
* Fix float limit override See: EleutherAI#2324 The float limit will be override with the previous int limit of multiple tasks are triggered together. This PR fix this issue * Update evaluator.py * Update evaluator.py
maaxap
pushed a commit
to maaxap/lm-evaluation-harness
that referenced
this pull request
Nov 16, 2024
* Fix float limit override See: EleutherAI#2324 The float limit will be override with the previous int limit of multiple tasks are triggered together. This PR fix this issue * Update evaluator.py * Update evaluator.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #2324
The float limit will be override with the previous int limit of multiple tasks are triggered together.
This PR fix this issue