Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new benchmark: Catalan bench #2154

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

zxcvuser
Copy link
Contributor

CatalanBench is a benchmark for tasks in Catalan that cover several evaluation areas. The datasets consist of professional translations of relevant English datasets and newly created datasets in Catalan. The README.md contains detailed information on all the tasks included in the benchmark.

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2024

CLA assistant check
All committers have signed the CLA.

lm_eval/tasks/catalan_bench/_cabreu_common_yaml Outdated Show resolved Hide resolved
lm_eval/tasks/catalan_bench/mgsm_direct_ca.yaml Outdated Show resolved Hide resolved
lm_eval/tasks/catalan_bench/_arc_ca_common_yaml Outdated Show resolved Hide resolved
lm_eval/tasks/catalan_bench/paws_ca.yaml Outdated Show resolved Hide resolved
@@ -0,0 +1,21 @@
group:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lm_eval/tasks/catalan_bench/paws_ca.yaml Show resolved Hide resolved
@zxcvuser
Copy link
Contributor Author

These are the changes done:

  • Added the benchmark info in lm_eval/tasks/README.md
  • Replaced "-" by "_" in the create_files script in flores_ca and added weight_by_size: false
  • Run linters
  • Remove grouping in mgsm, paws, and mgsm tasks (they were pointing to pre-existing benchmarks)
  • Changed "group" to "tag" in phrases_va, arc_ca and cabreu
  • Removed an if condition that was not being entered in any case in utils.py
  • Removed a duplicated "test_split: true" in xquad_ca

With these, it should all be fine now. Thank you!

Copy link
Collaborator

@haileyschoelkopf haileyschoelkopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zxcvuser , one last change before we can merge: would you be able to run the precommit/linter against create_yamls_flores_ca.py and fix the errors it raises? Thanks!

@zxcvuser
Copy link
Contributor Author

Hi @zxcvuser , one last change before we can merge: would you be able to run the precommit/linter against create_yamls_flores_ca.py and fix the errors it raises? Thanks!

Done! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants