-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"fixed" sampling with old <eos> method #12
base: main
Are you sure you want to change the base?
Conversation
Because of the mismatch between overall length and image length, it would end up broadcasting into a weird shape. This fixes that by slicing the text off first.
3019efd
to
587418d
Compare
@sdtblck if this still doesn't work, we'll give the non-cached version on the same branch a try |
@sdtblck hmm, i don't see the logits mask being used at all, so it's likely going to be still broken with this old way of doing things |
sid seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@sdtblck yet another try