Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more numbering #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

No more numbering #11

wants to merge 5 commits into from

Conversation

rustyrussell
Copy link
Collaborator

On top of #10 so just use last commit...

Courtesy of "make -C tools/"

Signed-off-by: Rusty Russell <[email protected]>
Useful to tell the node to add an HTLC.

Signed-off-by: Rusty Russell <[email protected]>
Useful for skipping entire tests if something isn't supported.

Signed-off-by: Rusty Russell <[email protected]>
Requires 323e4f6288f6b66862e8c5819fb651766c908708 in c-lightning.

Signed-off-by: Rusty Russell <[email protected]>
This makes it more readable and far simpler to renumber.

Signed-off-by: Rusty Russell <[email protected]>
Copy link
Collaborator

@niftynei niftynei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so good. intuitively, it feels to me like the + and * semantics would be easier to understand if swapped; with + signifying "new step" and * signifying "bullet point, list continuation". this is swapped from their current semantics.

otherwise 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants