Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERL-270: github: workflows: nemos-images: build qemu-arm64 targets #44

Merged
merged 9 commits into from
Sep 19, 2023

Conversation

IsaacJT
Copy link
Collaborator

@IsaacJT IsaacJT commented Aug 17, 2023

This makes use of the Kiwi boxed build plugin to create an arm64 VM.

Resolves #32

@IsaacJT IsaacJT self-assigned this Aug 17, 2023
@IsaacJT IsaacJT added the WIP Work In Progress label Aug 17, 2023
@IsaacJT IsaacJT force-pushed the ERL-270-github-arm64 branch 10 times, most recently from e742922 to e9ba2d2 Compare August 29, 2023 07:59
@IsaacJT IsaacJT force-pushed the ERL-270-github-arm64 branch 4 times, most recently from 85e2a09 to 1cc0993 Compare September 7, 2023 08:44
@IsaacJT IsaacJT added this to the NemOS Cycle 8 milestone Sep 11, 2023
@IsaacJT IsaacJT changed the title ERL-270: github: workflows: nemos-images: add qemu-arm64 build action ERL-270: github: workflows: nemos-images: build qemu-arm64 targets Sep 11, 2023
@IsaacJT IsaacJT force-pushed the ERL-270-github-arm64 branch 3 times, most recently from 705b66f to 46013be Compare September 11, 2023 15:56
@IsaacJT IsaacJT removed the WIP Work In Progress label Sep 13, 2023
@IsaacJT
Copy link
Collaborator Author

IsaacJT commented Sep 13, 2023

Finally ready for review :)

Add snakeoil private keys to allow signing dm-verity images inside a
boxbuild environment.

Signed-off-by: Isaac True <[email protected]>
Not all kernels ship with these built-in, so add it to the initrd
to allow those systems to boot with a virtio devices.

Signed-off-by: Isaac True <[email protected]>
This makes use of the kiwi box build plugin to create an arm64 VM.

Additionally, roll the spread step into the build step. This adds more
complication to the build step, but allows us to test each target
individually without running out of resources. Spread does not have a
way to limit how many VMs are created, and as more and more targets are
added, we quickly run out of resources on the GitHub runners.

Signed-off-by: Isaac True <[email protected]>
Copy link
Collaborator

@ahresse ahresse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main question that got answered: snakeoil keys stored in the git instead of ssl-cert package generation (/var/lib/dpkg/info/ssl-cert.postinst) -> ok, not suited for kiwi-boxed-plugin.

LGTM

Copy link

@m-kat m-kat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@IsaacJT IsaacJT merged commit 4aa94ed into master Sep 19, 2023
13 checks passed
@IsaacJT IsaacJT deleted the ERL-270-github-arm64 branch September 19, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building arm64 images using GitHub actions
3 participants