Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves world launching #62

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Improves world launching #62

merged 1 commit into from
Jul 5, 2024

Conversation

francocipollone
Copy link
Collaborator

🎉 New feature

Related to:

Summary

  • Adds GUI config a base for all the worlds
    • A substitution was necessary
  • Removes gz classic reference for the office world
  • Fix a minor bug where joiint_states topic weren't correctly setup for office world (gazebo worlds need to be named: gazebo_world due to a limitation on the architecture for multiple andinos)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)

@francocipollone
Improves world launching
fe15c47 
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone francocipollone requested review from Voldivh and removed request for lneumarkt July 5, 2024 19:12
Voldivh
Voldivh approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@Voldivh Voldivh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 6776639 into humble Jul 5, 2024
2 checks passed
@francocipollone francocipollone deleted the francocipollone/gui_config_clean_office_world branch July 5, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voldivh Voldivh Voldivh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @Voldivh