Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay stamped cmd vel #282

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

garyservin
Copy link
Contributor

🦟 Bug fix

Fixes #281

Summary

This remaps the diff_drive controller velocity command input to /cmd_vel_stamped and adds a relay node that transforms any message received in the /cmd_vel topic (unstamped) and stamps a header to it and republishes to /cmd_vel_stamped. This also changes the keyboard and joystick teleop nodes to use stamped messages and send them directly to the /cmd_vel_stamped topic

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @garyservin as always! This will be important mainly as Nav2 is switching its default to stamped Twist! Thanks!

@francocipollone francocipollone merged commit 75b681c into Ekumen-OS:jazzy Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants