Simplify argument for rsp #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyservin
requested review from
francocipollone and
jballoffet
as code owners
Signed-off-by: Gary Servin <[email protected]>
garyservin
force-pushed
the
simplify-rsp-arguments
branch
from
c63a01f to
59006fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Simplify arguments for the robot software publisher node. The robot description node needs to run always and was already hardcoded to True. Also reuse the andino_description.launch.py in the view_andino.launch.py launchfile. Lastly, ran
black --skip-string-normalizationagainst these 2 launchfile to fix some linting issues.Test it
ros2 launch andino_description andino_description.launch.pyros2 launch andino_description view_andino.launch.pyThese commands should work like they did before.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.