Applied necessary changes to docs and docker files for Jazzy #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JesusSilvaUtrera <[email protected]>
JesusSilvaUtrera
requested review from
francocipollone and
jballoffet
as code owners
jballoffet
reviewed
Sep 17, 2024
jballoffet
reviewed
Sep 17, 2024
jballoffet
reviewed
Sep 17, 2024
jballoffet
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Thanks @JesusSilvaUtrera! I left some minor comments, PTAL.
Signed-off-by: JesusSilvaUtrera <[email protected]>
jballoffet
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #266
Summary
This PR adds to the
jazzybranch the necessary changes for the code to work on Jazzy, both with docker and directly Ubuntu 24.Test it
Follow the instructions on the README to test both locally or with the docker environment.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.