Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds discord link #253

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Adds discord link #253

merged 2 commits into from
Jun 5, 2024

Conversation

francocipollone
Copy link
Collaborator

🎉 New feature

Summary

Adds discord link

image

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)

Signed-off-by: Franco Cipollone <[email protected]>
@LolaSegura
Copy link
Collaborator

LolaSegura commented Jun 5, 2024

LGTM!

One suggestion, I would increment the separation of the image from the text. You can do this by adding a hspace=<space_size> to the image tag, the result is something like this:
<img src="docs/discord-mark-blue.png" width=30 hspace="20"/>](https://discord.gg/tHhH32CTHu) Join our Discord and contribute to the community!
Screenshot from 2024-06-05 16-15-45

For me this way looks a bit better, but feel free to leave it as it is.

@francocipollone francocipollone merged commit e29e0de into humble Jun 5, 2024
4 checks passed
@francocipollone francocipollone deleted the francocipollone/discord branch June 5, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants