-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Arduino diagram #249
Add new Arduino diagram #249
Conversation
Signed-off-by: JesusSilvaUtrera <[email protected]>
andino_description/test/__pycache__/test_xacro_processing.cpython-310-pytest-6.2.5.pyc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JesusSilvaUtrera! I left some comments, PTAL.
Signed-off-by: JesusSilvaUtrera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, this is super useful.
+1 to Javi's comments.
I wonder if it makes sense to also integrate here the stepup regulator.
I was thinking of doing 3 diagrams: this one for the arduino, another one for the Raspberry Pi and the final one for the power, so the stepup would be placed there. |
Signed-off-by: JesusSilvaUtrera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JesusSilvaUtrera! Left some comments, PTAL.
Signed-off-by: JesusSilvaUtrera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @JesusSilvaUtrera!
🎉 New feature
Part of #239
Summary
This PR is just to add the new diagram for the Arduino Nano, motors and IMU with the changes from the firmware, in order to delete the warning on the
README.md
inandino_hardware
package.Just FYI @jballoffet: I didn't replace the 5V and GND for their electric symbols becuase when I tried it, the symbols had to be really small and I think at the end the diagram became less clear.
Test it
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.