Process xacro file test #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JesusSilvaUtrera <[email protected]>
JesusSilvaUtrera
requested review from
francocipollone and
jballoffet
as code owners
|
The only doubt I have here is whether it would be necessary to add to the documentation the test part or not. |
Signed-off-by: JesusSilvaUtrera <[email protected]>
francocipollone
previously approved these changes
May 14, 2024
jballoffet
reviewed
May 15, 2024
jballoffet
reviewed
May 15, 2024
jballoffet
reviewed
May 15, 2024
jballoffet
reviewed
May 15, 2024
jballoffet
reviewed
May 15, 2024
jballoffet
reviewed
May 15, 2024
Signed-off-by: JesusSilvaUtrera <[email protected]>
JesusSilvaUtrera
dismissed stale reviews from francocipollone and jballoffet
via
942eed9
jballoffet
reviewed
May 15, 2024
Signed-off-by: JesusSilvaUtrera <[email protected]>
|
@jballoffet all comments addressed. |
jballoffet
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #92
Summary
Added a pytest unit test to process the main xacro file (
andino.urdf.xacro) to check it is well formatted.Test it
Build the package and then you can test it running
colcon test --packages-select andino_description --event-handler=console_direct+ --pytest-args -k test_xacro_processing. You will see in the therminal the output of the test and if there is any error.Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.