Allow custom configuration

[JesusSilvaUtrera]

🎉 New feature

Closes #135 and #136

Summary

I have continued the work on these issues to add the possibility to pass arguments to the xacro file directly from the launch file. I created a hardware.yaml in the config folder to load the params from there instead of hardcoding them in the andino_control.xacro file.

I have also updated the README.md with these new features.

Test it

You can test that it works running ros2 launch andino_description view_andino.launch.py, which executes RViz and the robot_state_publisher to check that everything remains as before, but now more parameterized.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[JesusSilvaUtrera]

The arguments for the xacro are being passed directly inside the launch file, not as arguments of the launch files (I don't know if this was the expected result, IMO it is easier to understand this way, just changing the path in the launch file).

[francocipollone]

Thanks for the contribution

[francocipollone]

The arguments for the xacro are being passed directly inside the launch file, not as arguments of the launch files (I don't know if this was the expected result, IMO it is easier to understand this way, just changing the path in the launch file).

That's ok and also expected behavior.
From a user perspective it is useful to be able to indicate other .yaml file to be used instead the default one, however the parameters are always read from a yaml file.

[jballoffet]

Overall changes LGTM, I left some comments, PTAL. Thanks!

[JesusSilvaUtrera]

Overall changes LGTM, I left some comments, PTAL. Thanks!

One little question: Franco left a comment about maybe moving the andino_control.urdf.xacro to andino_control package, but I think it is better to leave it here, as that would create a dependency between andino_description and andino_control. wdyt?

[jballoffet]

Overall changes LGTM, I left some comments, PTAL. Thanks!

One little question: Franco left a comment about maybe moving the andino_control.urdf.xacro to andino_control package, but I think it is better to leave it here, as that would create a dependency between andino_description and andino_control. wdyt?

Good question. Let's keep it as is on this PR and if needed, send another PR for moving the xacro file to the andino_control package.

[jballoffet]

LGTM, thanks @JesusSilvaUtrera!