Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shell unit tests #242

Merged
merged 1 commit into from
May 8, 2024
Merged

Add Shell unit tests #242

merged 1 commit into from
May 8, 2024

Conversation

jballoffet
Copy link
Member

🎉 New feature

Related: #88

Summary

This PR adds Shell unit tests.

Test it

Tested by running the following commands and ensuring code builds and tests build and pass:

pio run

and

pio test --environment=desktop

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jballoffet jballoffet force-pushed the jballoffet/add-shell-tests branch from 319968d to 043028a Compare May 5, 2024 19:21
Signed-off-by: Javier Balloffet <[email protected]>
@jballoffet jballoffet force-pushed the jballoffet/add-shell-tests branch from 043028a to eb22d1b Compare May 5, 2024 19:24
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impecable! LGTM!

@jballoffet
Copy link
Member Author

Thanks @francocipollone for the review!

@jballoffet jballoffet merged commit a609f4e into humble May 8, 2024
4 checks passed
@jballoffet jballoffet deleted the jballoffet/add-shell-tests branch May 8, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants