Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matches convention with cmd_vel and odom topics. #223

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Feb 13, 2024

🎉 New feature

Related to #190

Summary

Matches cmd_vel and odom convention on topics. This enhances easier integration with other layers/technologies.

  • Adds remapping to controller_manager's diff_controller node.
    • diff_controller/odom -> odom
    • diff_controller/cmd_vel_unstamped -> cmd_vel
  • Removes dependency on twist mux

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone francocipollone force-pushed the francocipollone/use_default_topics branch from a7b3a00 to a5ec243 Compare February 13, 2024 01:12
@francocipollone francocipollone force-pushed the francocipollone/use_default_topics branch from a5ec243 to 02b4b9e Compare February 13, 2024 01:12
jballoffet
jballoffet previously approved these changes Feb 13, 2024
Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left two minor nits, thanks!

andino_control/launch/andino_control.launch.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Franco Cipollone <[email protected]>
Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francocipollone francocipollone merged commit 8aa352d into humble Feb 14, 2024
4 checks passed
@francocipollone francocipollone deleted the francocipollone/use_default_topics branch February 14, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants