Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Encoder unit tests #214

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Add Encoder unit tests #214

merged 1 commit into from
Feb 7, 2024

Conversation

jballoffet
Copy link
Member

@jballoffet jballoffet commented Jan 20, 2024

🎉 New feature

Related: #88

Summary

This PR adds Encoder unit tests.

Note: this PR is expected to be submitted after #213.

Test it

Tested by running the following commands and ensuring code builds and tests build and pass:

pio run

and

pio test --environment=desktop

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jballoffet jballoffet force-pushed the jballoffet/add-encoder-tests branch from a43a227 to 14cf41e Compare February 2, 2024 10:06
francocipollone
francocipollone previously approved these changes Feb 6, 2024
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Javier Balloffet <[email protected]>
@jballoffet jballoffet force-pushed the jballoffet/add-encoder-tests branch from 14cf41e to 4335e3f Compare February 7, 2024 08:08
@jballoffet jballoffet merged commit 91e6029 into humble Feb 7, 2024
4 checks passed
@jballoffet jballoffet deleted the jballoffet/add-encoder-tests branch February 7, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants