Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Motor unit tests #211

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Add Motor unit tests #211

merged 2 commits into from
Feb 6, 2024

Conversation

jballoffet
Copy link
Member

@jballoffet jballoffet commented Jan 14, 2024

🎉 New feature

Related: #88

Summary

This PR adds Motor unit tests.

Note: this PR is expected to be submitted after #210.

Test it

Tested by running the following commands and ensuring code builds and tests build and pass:

pio run

and

pio test --environment=desktop

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jballoffet jballoffet force-pushed the jballoffet/add-motor-tests branch from b0b04b2 to d77a78b Compare January 17, 2024 22:07
@jballoffet jballoffet force-pushed the jballoffet/add-motor-tests branch from d77a78b to 1e89a94 Compare February 2, 2024 09:57
Signed-off-by: Javier Balloffet <[email protected]>
@jballoffet jballoffet force-pushed the jballoffet/add-motor-tests branch from 1a13704 to 0f2f76c Compare February 2, 2024 19:07
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jballoffet jballoffet merged commit 306efd4 into humble Feb 6, 2024
4 checks passed
@jballoffet jballoffet deleted the jballoffet/add-motor-tests branch February 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants