Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWM output interface and the Arduino implementation #209

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

jballoffet
Copy link
Member

@jballoffet jballoffet commented Jan 14, 2024

🎉 New feature

Related: #87

Summary

This PR adds a PWM output interface and the corresponding Arduino implementation.

More PRs will be sent to keep improving the code structure.

Note: this PR is expected to be submitted after #208.

Test it

Tested by performing manual integration tests on the robot hardware.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jballoffet jballoffet force-pushed the jballoffet/add-pwm-out-interface branch from 5088a58 to 211b861 Compare January 31, 2024 22:53
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jballoffet jballoffet merged commit dfc2cc9 into humble Feb 2, 2024
4 checks passed
@jballoffet jballoffet deleted the jballoffet/add-pwm-out-interface branch February 2, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants