Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arduino header file inclusion #207

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

jballoffet
Copy link
Member

@jballoffet jballoffet commented Jan 14, 2024

🎉 New feature

Related: #87

Summary

This PR fixes the Arduino include directives, replacing local paths with system ones.

More PRs will be sent to keep improving the code structure.

Note: this PR is expected to be submitted after #205.

Test it

WIP

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Javier Balloffet <[email protected]>
Signed-off-by: Javier Balloffet <[email protected]>
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jballoffet jballoffet merged commit 0d894b7 into humble Jan 31, 2024
3 checks passed
@jballoffet jballoffet deleted the jballoffet/fix-arduino-include branch January 31, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants