Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve app run loop #197

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Improve app run loop #197

merged 1 commit into from
Jan 31, 2024

Conversation

jballoffet
Copy link
Member

🎉 New feature

Related: #87

Summary

This PR improves the application run loop by creating two new functions, adjust_motors_speed and stop_motors.

More PRs will be sent to keep improving the code structure.

Test it

Tested by performing manual integration tests on the robot hardware.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jballoffet jballoffet force-pushed the jballoffet/improve-app-loop branch from 5e38c28 to e61be81 Compare January 7, 2024 12:52
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Javier Balloffet <[email protected]>
@jballoffet jballoffet force-pushed the jballoffet/improve-app-loop branch from e61be81 to 07cb64e Compare January 31, 2024 22:32
@jballoffet jballoffet merged commit 4c7a084 into humble Jan 31, 2024
3 checks passed
@jballoffet jballoffet deleted the jballoffet/improve-app-loop branch January 31, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants