Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Arduino Nano by providing a new Arduino configuration. #195

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

agalbachicar
Copy link
Member

@agalbachicar agalbachicar commented Dec 27, 2023

🎉 New feature

Summary

The README says that the main part is an Arduino Nano, but the Arduino Uno is configured instead. This PR adds the configuration for the Arduino Nano, so you can pick which development platform to use (tested with VSCode + PlatformIO).

Test it

Pick the board, build and deploy the firmware using VSCode + PlatformIO.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agalbachicar for contributing to Andino! I left one comment, PTAL.

andino_firmware/platformio.ini Show resolved Hide resolved
Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing to Andino!

@agalbachicar agalbachicar merged commit b4debd2 into humble Dec 28, 2023
3 checks passed
@agalbachicar agalbachicar deleted the agalbachicar/support_arduino_nano branch December 28, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants