Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements file to Dockerfile #168

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

lneumarkt
Copy link
Collaborator

🦟 Bug fix

Fixes #65

Summary

Adds the requirements.txt file to the Dockerfile.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francocipollone francocipollone merged commit 024b694 into humble Oct 11, 2023
2 checks passed
@francocipollone francocipollone deleted the lneumarkt/add_requirements_to_dockerfile branch October 11, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

requirements aren't being installed in development docker
2 participants