Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes main license file. #155

Merged

Conversation

francocipollone
Copy link
Collaborator

🦟 Bug fix

Fixes #

Summary

All the packages have licenses, no need to have this (following ROS guidelines)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Signed-off-by: Franco Cipollone <[email protected]>
Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francocipollone could you please add a link to the PR description to the ROS guidelines regarding licences (for tracking purposes)? Thanks!

@francocipollone
Copy link
Collaborator Author

@francocipollone could you please add a link to the PR description to the ROS guidelines regarding licences (for tracking purposes)? Thanks!

ros/rosdistro#38645 (review)

Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@francocipollone francocipollone merged commit 82abd7d into humble Sep 28, 2023
3 checks passed
@francocipollone francocipollone deleted the francocipollone/remove_unnecessary_license_file branch September 28, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants