-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch compose build error in actions #5
Conversation
raighnew
commented
Sep 26, 2024
I apologize for turning PR off/on again and again, the changes are now ready for review. |
d574702
to
47226f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflow 只是一个 Ci,用来检查能不能正常构建固件的,并不是默认配置或者推荐配置,所以对 workflow 的配置的修改不是很有必要
那你建议是移除workflow的更改么,这会导致action编译失败。
…On Sun, 29 Sep 2024 at 00:18, Ekko ***@***.***> wrote:
***@***.**** commented on this pull request.
workflow 只是一个 Ci,用来检查能不能正常构建固件的,并不是默认配置或者推荐配置,所以对 workflow 的配置的修改不是很有必要
—
Reply to this email directly, view it on GitHub
<#5 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSB55YELES4CHIG7YC5R2DZY3JDRAVCNFSM6AAAAABO33GSSCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZVGMYTAMRZGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
https://github.com/EkkoG/OpenWrt/actions/runs/9330839185 不会失败,为什么这个 PR 去掉 workflow 的更改会失败,因为改了 run.sh 吗 |
是的,增加 |
--exit-code-from Return the exit code of the selected service container. Implies --abort-on- 这个选项看起来只影响 exit-code,不太可能和空间相关,如果你有空间不足的情况,应该是真的空间不足了,而不是因为加了这个选项,请确认给docker 还有可用空间,桌面版docker 有空间限制,镜像之类的文建都会计算进去 |
我还没有弄清为什么会引起空间不足,我昨天在Actions测试过了 1. 在ubuntu-lastest 里先清理出了20G空间 2. docker
run之前再清理 docker image 空间。最后还是把提示空间不足,没弄懂,我看看假期找个时间再研究研究。
…On Mon, 30 Sept 2024 at 09:29, Ekko ***@***.***> wrote:
--exit-code-from Return the exit code of the selected service container.
Implies --abort-on-
这个选项看起来只影响
exit-code,不太可能和空间相关,如果你有空间不足的情况,应该是真的空间不足了,而不是因为加了这个选项,请确认给docker
还有可用空间,桌面版docker 有空间限制,镜像之类的文建都会计算进去
—
Reply to this email directly, view it on GitHub
<#5 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSB553R4LTYWXKE3ZF4L5TZZCSPBAVCNFSM6AAAAABO33GSSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRHAZTKNZUHE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
试了一下 https://github.com/EkkoG/OpenWrt/actions/runs/11098426991/job/30831085201#step:3:3712 不加 --exit-code-from 都会报错,只是 docker-compose 命令会成功所以 CI 绿了 |
我之前Build过成功一次,然后 opkg install 的时候发现空间不够,查资料发现 CONFIG_TARGET_ROOTFS_PARTSIZE 这个参数可以调整磁盘空间,是因为默认CONFIG_TARGET_ROOTFS_PARTSIZE为104M,空间不够安装packages了么 |
看起来确实相关,默认的大小装不下这么多包 |
那我们可以把CONFIG_TARGET_ROOTFS_PARTSIZE写在workflow里么,我看传统的编译方式也是这样做的。 |
可以,麻烦改一下 review 吧,准备合并 |
另外文件格式的调整建议单独 PR,这次可以一起合并 |
我把yaml格式的修改先revert了,只保留了run和PARTSIZE的修改,麻烦看一下和合并。 |
感谢你的贡献! |