fix: Typos & bugs

EhPanda/App/EhPandaApp.swift

@@ -33,19 +33,18 @@ struct EhPandaApp: App {
 }
 
 private extension EhPandaApp {
-    var setting: Setting? {
+    var setting: Setting {
         store.appState.settings.setting
     }
-    var accentColor: Color? {
-        setting?.accentColor
+    var accentColor: Color {
+        setting.accentColor
     }
     var preferredColorScheme: ColorScheme? {
-        setting?.colorScheme ?? .none
+        setting.colorScheme
     }
 
     func onStartTasks() {
         DispatchQueue.main.async {
-            store.dispatch(.initializeStates)
             store.dispatch(.fetchFavoriteNames)
             store.dispatch(.fetchUserInfo)
         }

EhPanda/App/Tools/AppEnvStorage.swift

@@ -8,7 +8,7 @@
 import SwiftyBeaver
 
 @propertyWrapper
-struct AppEnvStorage<T: Codable> {
+struct AppEnvStorage<T: Encodable> {
     private var key: String
 
     private var appEnv: AppEnv {

EhPanda/DataFlow/AppAction.swift

@@ -10,8 +10,7 @@ import Kanna
 import Foundation
 
 enum AppAction {
-    case replaceUser(user: User?)
-    case initializeStates
+    case replaceUser(user: User)
     case initializeFilter
     case clearDetailViewCommentContent
     case clearCommentViewCommentContent

EhPanda/DataFlow/Store.swift

@@ -41,13 +41,7 @@ final class Store: ObservableObject {
         switch action {
         // MARK: App Ops
         case .replaceUser(let user):
-            if let user = user {
-                appState.settings.user = user
-            }
-        case .initializeStates:
-            // swiftlint:disable unneeded_break_in_switch
-            break
-            // swiftlint:enable unneeded_break_in_switch
+            appState.settings.user = user
         case .initializeFilter:
             appState.settings.filter = Filter()
         case .saveAspectBox(let gid, let box):

EhPanda/Database/PersistenceAccessor.swift

@@ -82,7 +82,6 @@ extension PersistenceController {
             )
         )
         newMO.gid = gid
-        saveContext()
         return newMO
     }
 

EhPanda/View/Setting/SettingView.swift

@@ -89,7 +89,7 @@ private extension SettingView {
     func logout() {
         clearCookies()
         clearImageCaches()
-        store.dispatch(.replaceUser(user: nil))
+        store.dispatch(.replaceUser(user: User()))
     }
 
     func calculateDiskCachesSize() {