Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node modules directory to clean script #3707

Closed
wants to merge 1 commit into from
Closed

Conversation

fubhy
Copy link
Member

@fubhy fubhy commented Sep 30, 2024

I regularly need this when I come back to the repository after 1 or 2 weeks. Sometimes pnpm fails to properly fix up the node modules directory after an update to dependencies or the pnpm version(?) it seems.

Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: 4f0ef13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mikearnaldi
Copy link
Member

this is "clean-self-destruct" lol

@mikearnaldi
Copy link
Member

maybe as an option? I when I run clean it usually doesn't require cleaning node_modules

@fubhy
Copy link
Member Author

fubhy commented Oct 1, 2024

Tbh. I wish pnpm had a full-reinstall option where it wipes all node modules across the workspace. I just went to check, it doesn't have it ... Strangely, because I run into this quite often due to the large range of projects I jump in and out of.

But yeah, we can also make that a separate command or an option.

@mikearnaldi
Copy link
Member

wondering why I never encounter the same, I think I never had to clean node_modules and my local repo is old old old, maybe nix + pnpm it's isolating it from the rest who knows

@fubhy
Copy link
Member Author

fubhy commented Oct 1, 2024

wondering why I never encounter the same, I think I never had to clean node_modules and my local repo is old old old, maybe nix + pnpm it's isolating it from the rest who knows

Yah ... This is usually the kind of problem that more senior developers run into when they debug the difficult stuff.

@mikearnaldi
Copy link
Member

wondering why I never encounter the same, I think I never had to clean node_modules and my local repo is old old old, maybe nix + pnpm it's isolating it from the rest who knows

Yah ... This is usually the kind of problem that more senior developers run into when they debug the difficult stuff.

after senior developers there are 100x developers who just don't care and never have issues.

@fubhy
Copy link
Member Author

fubhy commented Oct 1, 2024

Woah, nevermind actually. I just found npkill.

pnpx npkill

@fubhy fubhy closed this Oct 1, 2024
@fubhy
Copy link
Member Author

fubhy commented Oct 1, 2024

wondering why I never encounter the same, I think I never had to clean node_modules and my local repo is old old old, maybe nix + pnpm it's isolating it from the rest who knows

Yah ... This is usually the kind of problem that more senior developers run into when they debug the difficult stuff.

after senior developers there are 100x developers who just don't care and never have issues.

I was trolling friend

@fubhy fubhy deleted the node-modules-clean branch October 1, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants