Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentelemetry): add withActiveSpan function to attach Effect to current Span #3705

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

Schniz
Copy link
Contributor

@Schniz Schniz commented Sep 30, 2024

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Added withActiveSpan function to attach an Effect to the current Span from OpenTelemetry's context propagation. This allows setting up OpenTelemetry outside of Effect and attaching to a parent span. The function checks for an active span and returns the original effect if none is found.

Related

…current Span

Added `withActiveSpan` function to attach an Effect to the current Span from OpenTelemetry's context propagation. This allows setting up OpenTelemetry outside of Effect and attaching to a parent span. The function checks for an active span and returns the original effect if none is found.
Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: 9957590

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/opentelemetry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,19 @@
---
"@effect/opentelemetry": minor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make this a patch (as this package isn't API stable yet)

@Schniz Schniz requested a review from tim-smart October 1, 2024 06:10
.changeset/gorgeous-llamas-invent.md Outdated Show resolved Hide resolved
packages/opentelemetry/src/internal/tracer.ts Outdated Show resolved Hide resolved
@tim-smart tim-smart merged commit 534abce into Effect-TS:main Oct 1, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants