Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Fix link to Equivalence API #1861

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Conversation

strogonoff
Copy link
Contributor

@strogonoff strogonoff commented Jan 5, 2024

Currently, the link 404s. The link in this PR appears to be the intended URL.

Pull Requests

We welcome contributions via pull requests! Here are some guidelines to help you get started:

  1. Fork the repository and clone it to your local machine.
  2. Create a new branch for your changes: git checkout -b my-new-feature
  3. Install dependencies: pnpm install ([email protected])
  4. Make your changes and add tests if applicable.
  5. Run the tests: pnpm test
  6. Create a changeset for your changes: before committing your changes, create a changeset to document the modifications. This helps in tracking and communicating the changes effectively. To create a changeset, run the following command: pnpm changeset.
  7. Commit your changes: after creating the changeset, commit your changes with a descriptive commit message: git commit -am 'Add some feature'.
  8. Push your changes to your fork: git push origin my-new-feature.
  9. Open a pull request against our main branch.

Pull Request Guidelines

  • Please make sure your changes are consistent with the project's existing style and conventions.
  • Please write clear commit messages and include a summary of your changes in the pull request description.
  • Please make sure all tests pass and add new tests as necessary.
  • If your change requires documentation, please update the relevant documentation.
  • Please be patient! We will do our best to review your pull request as soon as possible.

Copy link

changeset-bot bot commented Jan 5, 2024

⚠️ No Changeset found

Latest commit: 3afdacf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fubhy
Copy link
Member

fubhy commented Jan 5, 2024

That's the wrong link though ;-)

This is where the new api docs are: https://effect-ts.github.io/effect/schema/Equivalence.ts.html

@fubhy
Copy link
Member

fubhy commented Jan 5, 2024

Thanks for pointing this out. I've also updated the links for platform and cli. These were all still pointing at the old pre-monorepo api docs. #1862

@fubhy fubhy merged commit 2493bf3 into Effect-TS:main Jan 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants