-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix platform exports #1858
Fix platform exports #1858
Conversation
🦋 Changeset detectedLatest commit: 47714b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@tim-smart The |
Yeah it was removed as the server modules were ending up in browser bundles. |
@tim-smart this should be better then |
The Http modules were excluded from the index.ts module as we have the /HttpClient and /HttpServer modules which re-export everything that is needed. Also we would probably want to prefix everything if we were to add it to index (HttpApp, HttpHeaders etc) |
2c5eed5
to
47714b1
Compare
Aaah, sorry... So you are saying that this was intentional and this PR should be closed? Sorry I didn't understand you comment at first ;-) |
At this stage I will close this. We will be evaluating a POC restructuring of platform soon, and we can re-evaluate the http modules at the same time. |
No description provided.