Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix platform exports #1858

Closed
wants to merge 4 commits into from
Closed

Fix platform exports #1858

wants to merge 4 commits into from

Conversation

fubhy
Copy link
Member

@fubhy fubhy commented Jan 4, 2024

No description provided.

@fubhy fubhy requested a review from tim-smart as a code owner January 4, 2024 10:15
Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: 47714b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@effect/platform-node Patch
@effect/platform Patch
@effect/cli Patch
@effect/experimental Patch
@effect/platform-bun Patch
@effect/rpc-http Patch
@effect/platform-browser Patch
@effect/rpc-http-node Patch
@effect/rpc-nextjs Patch
@effect/rpc-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fubhy
Copy link
Member Author

fubhy commented Jan 4, 2024

@tim-smart The /platform package never had the default entrypoint. Was that intentional?

@tim-smart
Copy link
Member

Yeah it was removed as the server modules were ending up in browser bundles.

@fubhy
Copy link
Member Author

fubhy commented Jan 4, 2024

@tim-smart this should be better then

@tim-smart
Copy link
Member

The Http modules were excluded from the index.ts module as we have the /HttpClient and /HttpServer modules which re-export everything that is needed.

Also we would probably want to prefix everything if we were to add it to index (HttpApp, HttpHeaders etc)

@fubhy
Copy link
Member Author

fubhy commented Jan 4, 2024

The Http modules were excluded from the index.ts module as we have the /HttpClient and /HttpServer modules which re-export everything that is needed.

Also we would probably want to prefix everything if we were to add it to index (HttpApp, HttpHeaders etc)

Aaah, sorry... So you are saying that this was intentional and this PR should be closed? Sorry I didn't understand you comment at first ;-)

@tim-smart
Copy link
Member

At this stage I will close this. We will be evaluating a POC restructuring of platform soon, and we can re-evaluate the http modules at the same time.

@tim-smart tim-smart closed this Jan 5, 2024
@fubhy fubhy deleted the fix-platform-exports branch January 5, 2024 07:19
thewilkybarkid added a commit to PREreview/orcid-sync that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants