fixup edge cases in bash completion script

Effect-TS · Nov 20, 2023 · 34094a0 · 34094a0
1 parent 2599875
commit 34094a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/internal/cliApp.ts b/src/internal/cliApp.ts
@@ -197,11 +197,7 @@ const handleBuiltInOption = <A>(
           self.command,
           config,
           compgen
-        ).pipe(
-          Effect.flatMap((completions) =>
-            Effect.forEach(completions, (word) => Console.log(word), { discard: true })
-          )
-        )
+        ).pipe(Effect.flatMap(Effect.forEach((word) => Console.log(word), { discard: true })))
       }))
     }
     case "ShowWizard": {

diff --git a/src/internal/completion.ts b/src/internal/completion.ts
@@ -92,11 +92,11 @@ const createBashCompletionScript = (
      |_${rootCommand}_effect_cli_completions() {
      |  local CMDLINE
      |  local IFS=$'\\n'
-     |  CMDLINE=(--shell-type bash --shell-completion-index $COMP_CWORD)
+     |  CMDLINE=(--shell-type bash --shell-completion-index "\${COMP_CWORD}")
      |
      |  INDEX=0
-     |  for arg in \${COMP_WORDS[@]}; do
-     |    export COMP_WORD_$INDEX=\${arg}
+     |  for arg in "\${COMP_WORDS[@]}"; do
+     |    export COMP_WORD_$INDEX="\${arg}"
      |    (( INDEX++ ))
      |  done
      |