Fix add attributes feature

Edujugon · Apr 23, 2018 · c9e7c7c · c9e7c7c
1 parent 4ef0319
commit c9e7c7c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -224,10 +224,12 @@ $mapper->mergeXML($newXml, 'desiredParentTag');
 $mapper->wrapWith('tagName');
 ```
 
-#### Add attributes based on tagName
+#### Add attributes
 
 ```php
-$mapper-addAttributes('tagName', ['attr1' => 'value1', 'attr2' => 'value2');
+$mapper-addAttributes(['attr1' => 'value1', 'attr2' => 'value2']);
+or
+$mapper-addAttributes(['attr1' => 'value1', 'attr2' => 'value2'], 'tagName');
 ```
 
 Enjoy :)
diff --git a/src/XMLMapper.php b/src/XMLMapper.php
@@ -455,16 +455,16 @@ public function wrapWith($tagName)
     }
 
     /**
-     * Add attributes to the xml based on tagName
+     * Add attributes to the xml
      *
      * @param $tagName
      * @param array $attributes
      */
-    public function addAttributes($tagName, array $attributes)
+    public function addAttributes(array $attributes, $tagName = null)
     {
         $obj = $this->getObj();
 
-        if ($tagName === $obj->getName()) {
+        if (is_null($tagName) || $tagName === $obj->getName()) {
             $this->addAttributesToObj($obj, $attributes);
 
             return;

diff --git a/tests/XMLMapperTest.php b/tests/XMLMapperTest.php
@@ -334,7 +334,7 @@ public function add_attributes_to_parent_node()
 
         $this->assertNull($this->mapper->getAttribute('test'));
 
-        $this->mapper->addAttributes('bookstore', [ 'test' => 'found', 'test2' => 'found']);
+        $this->mapper->addAttributes([ 'test' => 'found', 'test2' => 'found']);
 
         $this->assertEquals('found', $this->mapper->getAttribute('test'));
         $this->assertEquals('found', $this->mapper->getAttribute('test2'));
@@ -347,7 +347,7 @@ public function add_attributes_to_direct_child_node()
 
         $this->assertNull($this->mapper->getElement('book')->getAttribute('test'));
 
-        $this->mapper->addAttributes('book', [ 'test' => 'found', 'test2' => 'found']);
+        $this->mapper->addAttributes([ 'test' => 'found', 'test2' => 'found'], 'book');
 
         $this->assertEquals('found', $this->mapper->getElement('book')->getAttribute('test'));
         $this->assertEquals('found', $this->mapper->getElement('book')->getAttribute('test2'));